fix: allow transport restart after close()#1647
Closed
matantsach wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
fix: allow transport restart after close()#1647matantsach wants to merge 3 commits intomodelcontextprotocol:mainfrom
matantsach wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
close() aborts _abortController but never resets it to undefined, so start() sees a truthy guard and throws "already started." Same issue in SSEClientTransport with _eventSource. Also reset _endpoint in SSE to avoid stale endpoint URLs after restart. Fixes modelcontextprotocol#1641 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: d4a7f1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
Contributor
Author
|
Hi — just checking in. All CI is green (build, tests across Node 20/22/24, Bun, Deno, conformance) and the changeset is included. Let me know if there's anything to adjust or if there are design concerns with the approach. |
Contributor
|
Thanks for this. The fix is right but the PR is conflicting with ~400 lines of test additions on main. Opening a fresh PR with the same approach plus clearing |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1641.
StreamableHTTPClientTransportandSSEClientTransportcannot be restarted afterclose()because internal guard variables are not reset toundefined.Changes
StreamableHTTPClientTransport.close(): Reset_abortControllertoundefinedafter aborting, sostart()can create a fresh controllerSSEClientTransport.close(): Reset_abortController,_eventSource, and_endpointtoundefined— clears both start guards and avoids stale endpoint URLs on restartTesting
StreamableHTTPClientTransport: start → close → start → send → verify functionalSSEClientTransport: start → close → start → send → verify functionalpnpm test:all,pnpm check:all)